Downgrade missing metadata file to <check_failure> when validation model output files. (#138)
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to check failure and remove early return. Resolves #138
This was referenced Oct 30, 2024
zkamvar
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
LGTM.
There is one caveat that if there are any custom metadata checks that require the metadata file, they will result in an exec_error and stop the validation process, but that's not a big issue since the check_failure will be there to indicate that the file does not exist.
elray1
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrade missing metadata file when checking model output submission to
<check_failure>and remove early return.Resolves #138